Comments on: Act Like a Senior Developer – About Clean Code

By: Me

Me — Wed, 06 Jan 2010 16:11:15 +0000

I have only one rot. Do not have any rots! All rots are just someone’s problem. This article is problem of guy who has problems with code understanding. He needs more practice and this problem will be solved. One man’s best practice is another worst nightmare. Brake the rules. Do whatever you want. Do wherever you want. Do everything your way. Never follow any loosers rules. No more “this sould be done this way”. Have your own opinion. Be free. ;) I did not tell you to do wrong! Just do it your way. Your way is the best way. Let loosers to make rots of doing your way. Loosers create rots and design patterns because they have no brains to think and understand. They have no fantazy to create. Only thing they can is to copy.

By: Giorgio Sironi

Giorgio Sironi — Sun, 06 Dec 2009 16:03:15 +0000

Good low-level advice (low in the sense that it is closer to the code than to the design :).

By: Tim Acheson

Tim Acheson — Thu, 03 Dec 2009 14:02:40 +0000

This is a nice refresher on some best practices in coding standards, thanks!

We use the ReSharper plug-in in Visual Studio 2008 which is very good at highlighting the worst bad practices, and it can often do any necessary recactoring for you with one click.

By: cortex

cortex — Tue, 01 Dec 2009 16:15:58 +0000

quite likely this was your intention:

// SOLUTION: how about this? I stil don't know why you need continue there? for (int i=0; i < items.size(); i++) { if (isVisible(items.get(i))) { doThis(); } }

By: Pavel

Pavel — Mon, 30 Nov 2009 08:46:06 +0000

Thank you Isa. We have to refresh our mind from time to time with such nice topics. The problem is that 99% of developers (including myself) swear at bad code but don’t improve it after review :) Appreciate your great work. Keep writing!

By: Java bookmark links, Nov 2009 – Week4 | bookmark-link

Java bookmark links, Nov 2009 – Week4 | bookmark-link — Sun, 29 Nov 2009 08:53:10 +0000

[...] about how to act like a senior developer coding , Ifs statement, loops statement and many best [...]

By: Steve

Steve — Sat, 28 Nov 2009 23:00:31 +0000

It is not clear what you intend to do with the last “Stupid Loop” still. In the bad example you return items(0) if isVisible is true. The looop is not needed at all. You do the same in the good example, but don’t change the isVisible flag. In the previous example, I would put the isVisible outside the loop.

By: Max’ Lesestoff zum Wochenende | PHP hates me - Der PHP Blog

Max’ Lesestoff zum Wochenende | PHP hates me - Der PHP Blog — Sat, 28 Nov 2009 05:59:54 +0000

[...] von Continous Integration in Arbit I can haz lolSQL? – Aaron Bassett SQL endlich in sexy! Act Like a Senior Developer – About Clean Code hmmm Share this on del.icio.usShare this on TechnoratiAdd this to Mister WongStumble upon [...]

By: Yusuf Arslan

Yusuf Arslan — Fri, 27 Nov 2009 23:43:04 +0000

Making code simpler is relocating the complexity. There is no method to eliminate it. The art is achieving the right balance. And usually art is not achievable by following some simple rules or a check list.

Your general point is really valuable and well explained with real life examples.

By: Isa Goksu

Isa Goksu — Fri, 27 Nov 2009 18:20:49 +0000

@vdaburon, I think that one is a good idea.

@gervais, as I told @laurent; if you can write your code like a poem, then I wouldn't mind. But honestly, I haven't seen any guy that can write a poem-like codes in my whole career. Even you code it like that, someone after you will come and change the all the rhyme of your code, and it will be unreadable (mess) later on. Having a huge methods are big signs of incorrect responsibility assignments. I'd say if you have a code like that and you have to do it that way, it's very likely to move that logic to another class which can take certain arguments while processing. Then it would be more testable, and you would satisfy SRP in your base class and new class.

And one more thing to whole comments: These are not the codes that I invent to satisfy article, these are the codes that I saw written by different senior guys which pisses me off. And as I mentioned in the article, this article is written for my relaxation. Thanks for great interest, everyone is welcome to contribute more techniques or samples. And keep in mind no one has to agree with me ;)